Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #1450

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Release #1450

merged 2 commits into from
Jul 31, 2023

Conversation

xiaoiver
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

xiaoiver and others added 2 commits July 31, 2023 19:33
* fix: merge anchor into modelmatrix #1440

* chore: commit changeset

* fix: billboard effect should work for Line under ortho camera #1442

* fix: dashline should be displayed as same as Canvas / SVG #1446

* chore: commit changeset

* fix: 手势事件因为冒泡而多次绑定 (#1448)

* chore: commit changeset

---------

Co-authored-by: zengyue ye <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@xiaoiver xiaoiver merged commit deaa7d8 into next Jul 31, 2023
5 checks passed
@xiaoiver xiaoiver deleted the release branch July 31, 2023 11:36
Comment on lines +1 to +11
import {
runtime,
Canvas,
CanvasEvent,
Line,
Text,
Rect,
Image,
Circle,
Path,
} from '@antv/g';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused imports Circle, Path, Rect, Text.
Comment on lines +13 to +19
import {
MeshPhongMaterial,
SphereGeometry,
DirectionalLight,
Mesh,
Plugin as Plugin3D,
} from '@antv/g-plugin-3d';

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused imports Mesh, MeshPhongMaterial, SphereGeometry.
await canvas.ready;
// use GPU device
const plugin = renderer.getPlugin('device-renderer');
const device = plugin.getDevice();

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable device.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant