Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #1585

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Release #1585

merged 2 commits into from
Nov 16, 2023

Conversation

xiaoiver
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

xiaoiver and others added 2 commits November 16, 2023 11:10
* fix: avoid generating redundant dom structure for document element #1578 (#1580)

* chore: commit changeset

* fix: isBillboard should work on Path

* chore: commit changeset

* feat: add keep aspect ratio in image #1577

* chore: commit changeset
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@xiaoiver xiaoiver merged commit 6d0af1d into next Nov 16, 2023
5 of 6 checks passed
@xiaoiver xiaoiver deleted the release branch November 16, 2023 03:14
transformFolder
.add(transformConfig, 'localPositionX', 0, 600)
.onChange((localPositionX) => {
const [lx, ly] = image.getLocalPosition();

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable lx.
transformFolder
.add(transformConfig, 'localPositionY', 0, 500)
.onChange((localPositionY) => {
const [lx, ly] = image.getLocalPosition();

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable ly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant