Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix sometime onfinish not invoke #1715

Merged
merged 1 commit into from
Jun 28, 2024
Merged

fix: fix sometime onfinish not invoke #1715

merged 1 commit into from
Jun 28, 2024

Conversation

Aarebecca
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / Document optimization
  • TypeScript definition update
  • Refactoring
  • Performance improvement
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

camera.gotoLandmark 有一定概率不会执行 onfinish 回调函数

问题原因: requestAnimationFrame 计时误差导致小概率情况下 elapsed === duration 从而不会执行下一帧而无法执行 endAnimation 方法


camera.gotoLandmark will not execute the onfinish callback with some probability

Cause: a timing error in 'requestAnimationFrame' causes a small probability of 'elapsed === duration' which prevents' endAnimation 'from executing the next frame

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@Aarebecca Aarebecca merged commit 39af11f into next Jun 28, 2024
5 checks passed
@Aarebecca Aarebecca deleted the fix/camera-animation branch June 28, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant