fix: rendering anomalies caused by element zIndex update #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustcc
reviewed
Apr 14, 2025
yvonneyx
approved these changes
Apr 14, 2025
wang1212
added a commit
that referenced
this pull request
Apr 14, 2025
* fix: rendering anomalies caused by element zIndex update (#1924) * chore: add changeset * chore(release): bump version (#1925) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
fixed #1910
💡 Background and solution
In #1921 , we fixed the rendering anomaly in 3 scenarios, but missed a typical case in an interactive scenario. If we do not have an element with
zIndex != 0in the child element during the update process, we will clear thesortedlist. However, if a new child element withzIndex != 0is mounted later, it is not enough to just check whether thesortedlist exists. We should check whether thesortedlist is empty. If it is empty, we will directly sort all child elements to get the correct rendering list.📝 Changelog
☑️ Self Check before Merge