Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: 迁移v4雷达图 #5968

Merged
merged 4 commits into from
Dec 22, 2023
Merged

docs: 迁移v4雷达图 #5968

merged 4 commits into from
Dec 22, 2023

Conversation

kun6696
Copy link
Contributor

@kun6696 kun6696 commented Dec 21, 2023 •
edited by pearmini
Loading

Checklist
  • npm test passes
  • benchmarks are included
  • commit message follows commit guidelines
  • documents are updated
Description of change

1、对于雷达图通过生成gridControllAngles，使得支持gridConnect: 'line'的配置生效。
2、添加v4雷达图的demo。

close: #5903

pearmini
pearmini requested changes Dec 22, 2023
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

效果很赞，一些小问题 👍

src/runtime/plot.ts Outdated Show resolved Hide resolved
src/component/axis.ts Outdated Show resolved Hide resolved
src/component/axis.ts Outdated Show resolved Hide resolved
pearmini
pearmini requested changes Dec 22, 2023
View reviewed changes
src/runtime/plot.ts Show resolved Hide resolved
pearmini
pearmini approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@pearmini pearmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先合并了，注释问题下一个 PR 修复即可。

@pearmini pearmini merged commit 5672324 into antvis:v5 Dec 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pearmini pearmini pearmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

迁移 4.0 简单雷达图
2 participants
@kun6696 @pearmini