Define and prove a naive deletion safety for zookeeper controller #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenjie Ma <[email protected]>
Signed-off-by: Wenjie Ma <[email protected]>
| @@ -27,7 +27,7 @@ use crate::kubernetes_cluster::{ | |||
| use crate::temporal_logic::{defs::*, rules::*}; | |||
| use crate::zookeeper_controller::{ | |||
| common::*, | |||
| proof::{common::*, safety, terminate}, | |||
| proof::{common::*, liveness::invariants as specific_invariants, liveness::terminate}, | |||
There was a problem hiding this comment.
Maybe name invariants.rs to helper_invariants.rs?
Signed-off-by: Wenjie Ma <[email protected]>
Signed-off-by: Wenjie Ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the very beginning of the safety property proof, and there are quite some factors to consider in terms of the specifications of the properties.
forall |req_msg| sent_by_controller(req_msg) /\ in_flight(req_msg) => requirement(req_msg)or!exists |req_msg| sent_by_controller(req_msg) /\ in_flight(req_msg) /\ !requirement(req_msg). Of course they are equivalent but are from different views.tla_forall(but I don't do it) instead of use aforalloutside theentailspredicate because the message is created during the execution.