Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pl/anvil embed frame updates #18

Closed
wants to merge 4 commits into from
Closed

Conversation

patapat
Copy link
Contributor

@patapat patapat commented Apr 15, 2024

Description of the change

Update AnvilEmbedFrame to be a function component, add style prop and update propTypes

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fixes #17

Dev Checklist

  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development
  • No previous tests unrelated to the changed code fail in development

@@ -0,0 +1 @@
/Users/patricklo/work/react-ui/packages/anvil-embed-frame
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete before merge?

@patapat patapat closed this Apr 19, 2024
@patapat
Copy link
Contributor Author

patapat commented Apr 19, 2024

Closed in favor of #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

style prop is not exposed in TS types for AnvilEmbedFrame
2 participants