Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rewrite of the popover module
There may come a day where anvil doesn't necessarily ship with bootstrap
If that day came, then a user wouldn't be able to use the popver module if they opted out of bootstrap
This PR moves to using floating ui: https://floating-ui.com/
which is probably the way to go for this type of behaviour
I've tried to make it backwards compatible,
but i suspect this rewrite might break someone's code, so it might want to be considered as a major version bump
the classnames have changed for example, so anyone overriding the styling would break
i've gone with prefix classnames like
ae-popover
so that we don't conflict with random cssI've tested it on the popover example app, as well as some weird edge cases we've seen in the forum before.
Note - i've deprecated the dismiss on scroll option as floating ui supports maintaining the popover position as the page is scrolled.