Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging is inadequate to enable successful diagnostic/troubleshooting #48

Closed
mbaumann-broad opened this issue Nov 8, 2023 · 1 comment · Fixed by #41
Closed

Logging is inadequate to enable successful diagnostic/troubleshooting #48

mbaumann-broad opened this issue Nov 8, 2023 · 1 comment · Fixed by #41
Labels
bug Something isn't working high priority Should be completed ASAP

Comments

@mbaumann-broad
Copy link
Collaborator

Current Behavior

Nothing is being written to the drs_downloader.log, even when there are errors in the download (such as unresolvable DRS URIs)

Desired Behavior

To enable effective support, including diagnosing /troubleshooting problems, the drs_downloader.log file must contain:

  • All the information output to the user/console
  • Date/timestamps for all log entries
  • Stack traces for all errors that occur

Found In

drs_downloader v0.1.5-rc.11 on running on macOS

@mbaumann-broad mbaumann-broad added bug Something isn't working high priority Should be completed ASAP labels Nov 8, 2023
@matthewpeterkort
Copy link
Collaborator

matthewpeterkort commented Nov 9, 2023

Looking over this again one of the the main issues is that the drs_downloader.log file should log everything and currently it just mirrors the normal logging options. So if the user doesn't specify the -v flag there aren't many logs to begin with.

EDIT: addressed/tested in 20ddbbc

@lbeckman314 lbeckman314 linked a pull request Nov 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority Should be completed ASAP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants