Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SparkPost: error on features incompatible with template_id #382

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

medmunds
Copy link
Contributor

Raise an AnymailUnsupportedFeature error when trying to use a template_id along with other content payload fields that SparkPost silently ignores when template_id is present:

  • attachments
  • inline images
  • extra headers
  • cc recipients (uses extra headers)
  • from_email
  • reply_to

(It's unclear if these used to cause API errors, or if they were supported with templates at some point and then quietly dropped.)

@medmunds medmunds added esp:SparkPost breaking Breaking change labels Jun 22, 2024
Raise an `AnymailUnsupportedFeature` error
when trying to use a `template_id` along with
other content payload fields that SparkPost
silently ignores when template_id is present.
@medmunds medmunds force-pushed the fix/sparkpost-template-limitations branch from 9b8e36b to c4b2e08 Compare June 22, 2024 21:48
@medmunds medmunds merged commit c4b2e08 into main Jun 22, 2024
63 checks passed
@medmunds medmunds deleted the fix/sparkpost-template-limitations branch September 8, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant