ATOR-193 - Metrics service introduction #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floodcode
reviewed
Mar 28, 2024
floodcode
reviewed
Mar 28, 2024
src/app.ts
Outdated
| const INSTANCE = process.env.INSTANCE ?? '10.1.244.1:9190'; | ||
| const JOB = process.env.JOB ?? 'consulagentonionoo'; | ||
|
|
||
| app.get('/metrics/:query', async (req, res) => { |
There was a problem hiding this comment.
I would move all API (express) related calls and initializations to separate file (e.g. api.ts)
yumirkov
force-pushed
the
feature/ATOR-193-metrics-service-init
branch
from
ba9e267
to
9e6e268
Compare
floodcode
reviewed
Mar 29, 2024
floodcode
reviewed
Mar 29, 2024
floodcode
reviewed
Mar 29, 2024
floodcode
approved these changes
Apr 1, 2024
yumirkov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.