ATOR-240 - Add relay search endpoint #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yumirkov
changed the title
yumirkov
changed the title
floodcode
reviewed
Apr 15, 2024
| @@ -10,9 +11,11 @@ const vmService = new VictoriaMetricsService(process.env.VICTORIA_METRICS_ADDRES | |||
|
|
|||
| const CLUSTER = process.env.CLUSTER ?? 'local'; | |||
| const ENV = process.env.ENV ?? 'main'; | |||
| const ONIONOO_INSTANCE = process.env.ONIONOO_INSTANCE ?? '10.1.244.1:9190'; | |||
| const ONIONOO_INSTANCE = process.env.ONIONOO_INSTANCE ?? '10.1.244.1:9090'; | |||
There was a problem hiding this comment.
Can we change it to the ONIONOO_BASE_URL and pass full URL, not just hostname and port?
So in case onionoo endpoint changes to https, we won't need to make new PR of metrics-service
There was a problem hiding this comment.
No, it is used in two separate places.
What I can do is add protocol as en var.
floodcode
approved these changes
Apr 16, 2024
yumirkov
added a commit
that referenced
this pull request
Apr 23, 2024
ATOR-240 - Add relay search endpoint (#5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.