Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add JNI / Android support #101

Closed

Conversation

kanshi
Copy link
Contributor

@kanshi kanshi commented Oct 15, 2024

No description provided.

Co-authored-by: Hans-Christoph Steiner <[email protected]>
Co-authored-by: Torsten Grote <[email protected]>
@kanshi kanshi linked an issue Oct 15, 2024 that may be closed by this pull request
@kanshi kanshi assigned kanshi and yumirkov and unassigned kanshi Oct 15, 2024
@kanshi kanshi changed the title Add JNI / Android support (#96) Re-add JNI / Android support Oct 15, 2024
@tladesignz
Copy link
Collaborator

Ahh. Is --enable-android on by default? If so, we just need to invert that. It should be disabled by default. Then the CI builds should work.

I don't think it's necessary to CI build for Android. But if so, please don't change the config of it, but adapt the build so it doesn't expect stuff which won't be there.

@yumirkov yumirkov force-pushed the 100-build-failing-after-adding-androidjni-patches branch 5 times, most recently from 0bedf52 to ee4c235 Compare October 16, 2024 10:34
@yumirkov yumirkov force-pushed the 100-build-failing-after-adding-androidjni-patches branch from 5c2ecc8 to dff1862 Compare October 16, 2024 12:03
@yumirkov
Copy link
Contributor

@tladesignz please check this one
https://github.com/anyone-protocol/ator-protocol/blob/main/configure.ac#L359

@yumirkov yumirkov closed this Oct 24, 2024
@tladesignz tladesignz deleted the 100-build-failing-after-adding-androidjni-patches branch October 25, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failing after adding Android/JNI patches
3 participants