Skip to content

Commit

Permalink
Bug fix: If the organization is specified, it has to be used in the F…
Browse files Browse the repository at this point in the history
…ROM clause for Dockerfile-academy-all
  • Loading branch information
Dean Wampler committed Sep 4, 2020
1 parent 842c990 commit 54bf5b9
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ $(IMAGE_NAMES:%=%-image): echo
docker build \
$(DOCKER_TAGS:%=--tag $(ORGANIZATION)/${@:%-image=%}:%) \
--build-arg VERSION=$(ACADEMY_VERSION) \
--build-arg ORGANIZATION=$(ORGANIZATION) \
-f $(DOCKERFILE_BASE)-${@:%-image=%} stage

stage-base: stage/academy-base
Expand Down
8 changes: 5 additions & 3 deletions docker/Dockerfile-academy-all
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
FROM deanwampler/academy-base:latest
ARG VERSION
ARG ORGANIZATION
FROM ${ORGANIZATION}/academy-base:${VERSION}
ARG VERSION
LABEL maintainer="Anyscale Academy <[email protected]>"

ADD academy-all/academy-$VERSION /root/academy-$VERSION
RUN ls -al /root/academy-$VERSION
ADD academy-all/academy-${VERSION} /root/academy-${VERSION}
RUN ls -al /root/academy-${VERSION}
1 change: 1 addition & 0 deletions docker/Dockerfile-academy-base
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
FROM anyscale/ray:0.8.7
ARG VERSION
ARG ORGANIZATION
LABEL maintainer="Anyscale Academy <[email protected]>"

SHELL ["/bin/bash", "-o", "pipefail", "-c"]
Expand Down

0 comments on commit 54bf5b9

Please sign in to comment.