Skip to content

Commit

Permalink
fix: Tolerances for EKS nodes need to be ON_DEMAND
Browse files Browse the repository at this point in the history
Switches the ALL tolerance to ON_DEMAND, as taints must be unique to a tuple of (key, effect) in EKS, which wasn't possible with the ALL convention

Changes to be committed:
	modified:   eks-private/main.tf
	modified:   eks-public/main.tf
  • Loading branch information
brent-anyscale committed Sep 16, 2024
1 parent 966c4a7 commit d8642af
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
10 changes: 5 additions & 5 deletions examples/aws/eks-private/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ module "anyscale_eks_nodegroups" {
taints = [
{
key = "node.anyscale.com/capacity-type",
value = "ANY",
value = "ON_DEMAND",
effect = "NO_SCHEDULE",
}
]
Expand All @@ -255,7 +255,7 @@ module "anyscale_eks_nodegroups" {
taints = [
{
key = "node.anyscale.com/capacity-type",
value = "ANY",
value = "ON_DEMAND",
effect = "NO_SCHEDULE",
}
]
Expand Down Expand Up @@ -309,7 +309,7 @@ module "anyscale_eks_nodegroups" {
},
{
key = "node.anyscale.com/capacity-type",
value = "ANY",
value = "ON_DEMAND",
effect = "NO_SCHEDULE",
},
{
Expand Down Expand Up @@ -345,7 +345,7 @@ module "anyscale_eks_nodegroups" {
},
{
key = "node.anyscale.com/capacity-type",
value = "ANY",
value = "ON_DEMAND",
effect = "NO_SCHEDULE",
},
{
Expand Down Expand Up @@ -382,7 +382,7 @@ module "anyscale_eks_nodegroups" {
},
{
key = "node.anyscale.com/capacity-type",
value = "ANY",
value = "SPOT",
effect = "NO_SCHEDULE",
},
{
Expand Down
10 changes: 5 additions & 5 deletions examples/aws/eks-public/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ module "anyscale_eks_nodegroups" {
taints = [
{
key = "node.anyscale.com/capacity-type",
value = "ANY",
value = "ON_DEMAND",
effect = "NO_SCHEDULE",
}
]
Expand All @@ -255,7 +255,7 @@ module "anyscale_eks_nodegroups" {
taints = [
{
key = "node.anyscale.com/capacity-type",
value = "ANY",
value = "ON_DEMAND",
effect = "NO_SCHEDULE",
}
]
Expand Down Expand Up @@ -309,7 +309,7 @@ module "anyscale_eks_nodegroups" {
},
{
key = "node.anyscale.com/capacity-type",
value = "ANY",
value = "ON_DEMAND",
effect = "NO_SCHEDULE",
},
{
Expand Down Expand Up @@ -345,7 +345,7 @@ module "anyscale_eks_nodegroups" {
},
{
key = "node.anyscale.com/capacity-type",
value = "ANY",
value = "ON_DEMAND",
effect = "NO_SCHEDULE",
},
{
Expand Down Expand Up @@ -382,7 +382,7 @@ module "anyscale_eks_nodegroups" {
},
{
key = "node.anyscale.com/capacity-type",
value = "ANY",
value = "SPOT",
effect = "NO_SCHEDULE",
},
{
Expand Down

0 comments on commit d8642af

Please sign in to comment.