-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Release for Kubernetes Anyscale Foundation Modules #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On branch brent/k8s Changes to be committed: modified: .gitignore new file: .pre-commit-config.yaml new file: .terraform-docs.yml new file: .tflint.hcl new file: CHANGELOG.md modified: README.md modified: anyscale-k8s-helm/README.md modified: anyscale-k8s-helm/data.tf modified: anyscale-k8s-helm/helm-nvidia.tf modified: anyscale-k8s-helm/main.tf modified: anyscale-k8s-helm/outputs.tf modified: anyscale-k8s-helm/test/README.md modified: anyscale-k8s-helm/test/anyscale-aws-test/.terraform.lock.hcl modified: anyscale-k8s-helm/test/anyscale-aws-test/main.tf modified: anyscale-k8s-helm/test/anyscale-aws-test/variables.tf deleted: anyscale-k8s-helm/test/eksctltest.yaml modified: anyscale-k8s-helm/variables.tf modified: anyscale-k8s-helm/versions.tf new file: main.tf new file: outputs.tf new file: variables.tf new file: versions.tf
Changes to be committed: modified: .pre-commit-config.yaml
Changes to be committed: modified: .pre-commit-config.yaml modified: .tflint.hcl modified: README.md modified: anyscale-k8s-helm/README.md modified: anyscale-k8s-helm/helm-ingress.tf modified: anyscale-k8s-helm/main.tf modified: anyscale-k8s-helm/outputs.tf modified: anyscale-k8s-helm/test/anyscale-aws-test/.terraform.lock.hcl modified: anyscale-k8s-helm/test/anyscale-aws-test/main.tf modified: anyscale-k8s-helm/test/anyscale-aws-test/versions.tf modified: anyscale-k8s-helm/variables.tf modified: anyscale-k8s-helm/versions.tf modified: versions.tf
Also added the ability to enable/disable individual charts as part of the chart variable map. Changes to be committed: modified: anyscale-k8s-helm/README.md modified: anyscale-k8s-helm/helm-autoscaler.tf modified: anyscale-k8s-helm/helm-ingress.tf modified: anyscale-k8s-helm/helm-nvidia.tf modified: anyscale-k8s-helm/variables.tf
Testing different ways to deal with helm-ingress and deleting NLBs. Changes to be committed: modified: ../../README.md modified: ../../helm-ingress.tf new file: ../../helm-metricsserver.tf modified: ../../main.tf modified: main.tf modified: ../../variables.tf
Changes to be committed: modified: README.md modified: anyscale-k8s-helm/helm-ingress.tf modified: anyscale-k8s-helm/main.tf modified: anyscale-k8s-helm/test/anyscale-aws-test/.terraform.lock.hcl modified: anyscale-k8s-helm/test/anyscale-aws-test/main.tf new file: modules/anyscale-k8s-configmap/main.tf new file: modules/anyscale-k8s-configmap/outputs.tf new file: modules/anyscale-k8s-configmap/test/anyscale-aws-test/main.tf new file: modules/anyscale-k8s-configmap/test/anyscale-aws-test/outputs.tf new file: modules/anyscale-k8s-configmap/test/anyscale-aws-test/variables.tf new file: modules/anyscale-k8s-configmap/test/anyscale-aws-test/versions.tf new file: modules/anyscale-k8s-configmap/test/anyscale-gcp-test/main.tf new file: modules/anyscale-k8s-configmap/test/anyscale-gcp-test/outputs.tf new file: modules/anyscale-k8s-configmap/test/anyscale-gcp-test/variables.tf new file: modules/anyscale-k8s-configmap/test/anyscale-gcp-test/versions.tf new file: modules/anyscale-k8s-configmap/variables.tf new file: modules/anyscale-k8s-configmap/versions.tf modified: variables.tf
Standardizing the names for resources created during tests. Changes to be committed: modified: anyscale-k8s-helm/test/anyscale-aws-test/main.tf
Changes to be committed: deleted: anyscale-k8s-helm/test/anyscale-aws-test/.terraform.lock.hcl modified: modules/anyscale-k8s-configmap/test/anyscale-aws-test/main.tf renamed: anyscale-k8s-helm/README.md -> modules/anyscale-k8s-helm/README.md renamed: anyscale-k8s-helm/data.tf -> modules/anyscale-k8s-helm/data.tf renamed: anyscale-k8s-helm/helm-autoscaler.tf -> modules/anyscale-k8s-helm/helm-autoscaler.tf renamed: anyscale-k8s-helm/helm-ingress.tf -> modules/anyscale-k8s-helm/helm-ingress.tf renamed: anyscale-k8s-helm/helm-metricsserver.tf -> modules/anyscale-k8s-helm/helm-metricsserver.tf renamed: anyscale-k8s-helm/helm-nvidia.tf -> modules/anyscale-k8s-helm/helm-nvidia.tf renamed: anyscale-k8s-helm/main.tf -> modules/anyscale-k8s-helm/main.tf renamed: anyscale-k8s-helm/outputs.tf -> modules/anyscale-k8s-helm/outputs.tf renamed: anyscale-k8s-helm/test/README.md -> modules/anyscale-k8s-helm/test/README.md renamed: anyscale-k8s-helm/test/anyscale-aws-test/main.tf -> modules/anyscale-k8s-helm/test/anyscale-aws-test/main.tf renamed: anyscale-k8s-helm/test/anyscale-aws-test/outputs.tf -> modules/anyscale-k8s-helm/test/anyscale-aws-test/outputs.tf renamed: anyscale-k8s-helm/test/anyscale-aws-test/variables.tf -> modules/anyscale-k8s-helm/test/anyscale-aws-test/variables.tf renamed: anyscale-k8s-helm/test/anyscale-aws-test/versions.tf -> modules/anyscale-k8s-helm/test/anyscale-aws-test/versions.tf renamed: anyscale-k8s-helm/test/anyscale-gcp-test/versions.tf -> modules/anyscale-k8s-helm/test/anyscale-gcp-test/versions.tf renamed: anyscale-k8s-helm/variables.tf -> modules/anyscale-k8s-helm/variables.tf renamed: anyscale-k8s-helm/versions.tf -> modules/anyscale-k8s-helm/versions.tf
Updates to k8s-configmap for when the aws-auth configmap is already present. Updates to helm modules. Changes to be committed: new file: examples/aws/eks-public/main.tf new file: examples/aws/eks-public/outputs.tf new file: examples/aws/eks-public/variables.tf new file: examples/aws/eks-public/versions.tf modified: modules/anyscale-k8s-configmap/main.tf modified: modules/anyscale-k8s-configmap/variables.tf modified: modules/anyscale-k8s-helm/helm-autoscaler.tf modified: modules/anyscale-k8s-helm/helm-ingress.tf modified: modules/anyscale-k8s-helm/helm-metricsserver.tf
Changes to be committed: modified: main.tf modified: outputs.tf modified: versions.tf modified: ../../../modules/anyscale-k8s-helm/README.md modified: ../../../modules/anyscale-k8s-helm/helm-metricsserver.tf modified: ../../../modules/anyscale-k8s-helm/helm-nvidia.tf new file: ../../../modules/anyscale-k8s-helm/helm-prometheus.tf modified: ../../../modules/anyscale-k8s-helm/outputs.tf modified: ../../../modules/anyscale-k8s-helm/variables.tf
Changes to be committed: modified: examples/aws/eks-public/main.tf modified: examples/aws/eks-public/outputs.tf modified: modules/anyscale-k8s-configmap/main.tf new file: modules/anyscale-k8s-namespace/main.tf new file: modules/anyscale-k8s-namespace/outputs.tf new file: modules/anyscale-k8s-namespace/test/anyscale-aws-test/main.tf new file: modules/anyscale-k8s-namespace/test/anyscale-aws-test/outputs.tf new file: modules/anyscale-k8s-namespace/test/anyscale-aws-test/variables.tf new file: modules/anyscale-k8s-namespace/test/anyscale-aws-test/versions.tf new file: modules/anyscale-k8s-namespace/variables.tf new file: modules/anyscale-k8s-namespace/versions.tf
Changes to be committed: modified: examples/aws/eks-public/main.tf modified: examples/aws/eks-public/outputs.tf new file: examples/aws/eks-public/sample_execution.txt modified: examples/aws/eks-public/variables.tf modified: modules/anyscale-k8s-helm/README.md modified: modules/anyscale-k8s-helm/variables.tf
Changes to be committed: deleted: sample_execution.txt
Changes to be committed: modified: main.tf
Changes to be committed: new file: eks-private/README.md new file: eks-private/main.tf new file: eks-private/outputs.tf new file: eks-private/variables.tf new file: eks-private/versions.tf new file: eks-public/README.md modified: eks-public/main.tf modified: eks-public/variables.tf
- ConfigMap now supports adding instance types to the configmap data. - Helm Charts ingress is fixed to build a NLB. Examples updated - EKS Public and Private examples updated to use the new configmap module. - EKS Public example dependencies updated. Changes to be committed: modified: examples/aws/eks-private/main.tf modified: examples/aws/eks-public/README.md modified: examples/aws/eks-public/main.tf modified: modules/anyscale-k8s-configmap/main.tf modified: modules/anyscale-k8s-configmap/test/anyscale-aws-test/main.tf modified: modules/anyscale-k8s-configmap/variables.tf modified: modules/anyscale-k8s-helm/README.md modified: modules/anyscale-k8s-helm/helm-ingress.tf modified: modules/anyscale-k8s-helm/test/anyscale-aws-test/main.tf modified: modules/anyscale-k8s-helm/variables.tf
Continuing to troubleshoot `terraform destroy` issues with the Ingress Helm Chart. Changes to be committed: modified: modules/anyscale-k8s-helm/helm-ingress.tf
Changes to be committed: new file: .github/CODEOWNERS new file: .github/ISSUE_TEMPLATE/bug-report.yml new file: .github/ISSUE_TEMPLATE/config.yml new file: .github/ISSUE_TEMPLATE/feature-request.yml new file: .github/ISSUE_TEMPLATE/security-issue.yml new file: .github/PULL_REQUEST_TEMPLATE.md new file: .github/create-release.yml new file: .github/labeler.yml new file: .github/workflows/branch-cleanup.yml new file: .github/workflows/create-release.yml new file: .github/workflows/labeler.yml new file: .github/workflows/main.yml
Changes to be committed: modified: .github/ISSUE_TEMPLATE/bug-report.yml modified: .github/ISSUE_TEMPLATE/feature-request.yml modified: .github/ISSUE_TEMPLATE/security-issue.yml
Added persistent-volume module which is unused at this time. Changes to be committed: modified: examples/aws/eks-public/README.md modified: examples/aws/eks-public/main.tf modified: examples/aws/eks-public/outputs.tf new file: modules/anyscale-k8s-configmap/README.md modified: modules/anyscale-k8s-helm/README.md modified: modules/anyscale-k8s-helm/helm-ingress.tf new file: modules/anyscale-k8s-namespace/README.md new file: modules/anyscale-k8s-persistent-volume/README.md new file: modules/anyscale-k8s-persistent-volume/main.tf new file: modules/anyscale-k8s-persistent-volume/outputs.tf new file: modules/anyscale-k8s-persistent-volume/test/anyscale-aws-test/main.tf new file: modules/anyscale-k8s-persistent-volume/test/anyscale-aws-test/outputs.tf new file: modules/anyscale-k8s-persistent-volume/test/anyscale-aws-test/variables.tf new file: modules/anyscale-k8s-persistent-volume/test/anyscale-aws-test/versions.tf new file: modules/anyscale-k8s-persistent-volume/variables.tf new file: modules/anyscale-k8s-persistent-volume/versions.tf
Changes to be committed: modified: modules/anyscale-k8s-persistent-volume/README.md modified: modules/anyscale-k8s-persistent-volume/variables.tf
The ConfigMap module supports the latest instance-type config which required changing from json to yaml. Additional tweaks to the examples to support the changes to the EKS Modules in the AWS repo. Changes to be committed: modified: examples/aws/eks-public/main.tf modified: examples/aws/eks-public/outputs.tf modified: modules/anyscale-k8s-configmap/README.md modified: modules/anyscale-k8s-configmap/main.tf modified: modules/anyscale-k8s-configmap/variables.tf
Additional updates to aws eks examples. Changes to be committed: modified: README.md modified: examples/aws/eks-private/README.md modified: examples/aws/eks-private/main.tf modified: examples/aws/eks-public/main.tf modified: modules/anyscale-k8s-helm/README.md modified: modules/anyscale-k8s-helm/helm-nvidia.tf modified: modules/anyscale-k8s-helm/variables.tf
Changes to be committed: modified: CHANGELOG.md modified: examples/aws/eks-private/README.md modified: examples/aws/eks-private/main.tf modified: examples/aws/eks-public/README.md modified: examples/aws/eks-public/main.tf
domcatalano
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR for v0.0.1 of the Kubernetes Anyscale Foundation Modules