Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IPAddr type #427

Merged
merged 3 commits into from
Jul 30, 2019
Merged

Add IPAddr type #427

merged 3 commits into from
Jul 30, 2019

Conversation

patrickmarabeas
Copy link
Collaborator

@patrickmarabeas patrickmarabeas commented Jun 18, 2019 •
edited
Loading

Implements fmt.Stringer

Fixes #420

Review of colleague's PR #534

@codecov
Copy link

codecov bot commented Jun 18, 2019 •
edited
Loading

Codecov Report

Merging #427 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #427   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         127    128    +1     
  Lines        2188   2192    +4     
=====================================
+ Hits         2188   2192    +4
Impacted Files Coverage Δ
05_stringer/patrickmarabeas/main.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b95bcc4...54920dc. Read the comment docs.

starfallz
starfallz previously approved these changes Jun 18, 2019
View reviewed changes
Copy link
Collaborator

@starfallz starfallz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like how you covered the boundaries, good job looks good, easy to read. Something super minor, i ended up not using Fprintln and just use Fprint so i dont have to add and expect \n everytime :)

@starfallz starfallz mentioned this pull request Jun 18, 2019
Closed
@patrickmarabeas
Copy link
Collaborator Author

@starfallz ah nice call! Will do this in my other labs as well.

Just a reminder to update the labels (under review / changes requested / approved by colleague) accordingly when you are reviewing!

@rokane rokane self-assigned this Jul 19, 2019
rokane
rokane previously requested changes Jul 19, 2019
View reviewed changes
Copy link
Member

@rokane rokane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good. A couple of super minor things and then this should be ready for merging. Just ping me once this is done and I will try to take a look asap 👍

@rokane rokane removed their assignment Jul 19, 2019
@patrickmarabeas patrickmarabeas requested a review from samuong as a code owner July 28, 2019 03:38
@patrickmarabeas
Add IPAddr type
382d7ef 
Implements fmt.Stringer

Closes Lab 05 (anz-bank#420)
@patrickmarabeas patrickmarabeas requested a review from rokane July 28, 2019 03:42
juliaogris
juliaogris approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@juliaogris juliaogris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliaogris juliaogris dismissed rokane’s stale review July 29, 2019 23:55

all addressed

@patrickmarabeas patrickmarabeas merged commit cab3b43 into anz-bank:master Jul 30, 2019
@patrickmarabeas patrickmarabeas deleted the lab-05-pm branch July 30, 2019 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaogris juliaogris juliaogris approved these changes

@starfallz starfallz starfallz left review comments

@anzboi anzboi Awaiting requested review from anzboi anzboi is a code owner

@anzdaddy anzdaddy Awaiting requested review from anzdaddy anzdaddy is a code owner

@camscale camscale Awaiting requested review from camscale

@joshcarp joshcarp Awaiting requested review from joshcarp

@linuxmonk linuxmonk Awaiting requested review from linuxmonk

@pentaphobe pentaphobe Awaiting requested review from pentaphobe pentaphobe is a code owner

@samuong samuong Awaiting requested review from samuong samuong is a code owner

@rokane rokane Awaiting requested review from rokane rokane is a code owner

Assignees
No one assigned
Labels
lab5 Merge me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lab 05 - Stringer
4 participants
@patrickmarabeas @juliaogris @rokane @starfallz