v1.17: ensure that SPL downstream tests always succeed #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SPL repo upgraded their dependencies version to v1.18.2 (solana-labs/solana-program-library#6278). it caused two problems
the patch script that is in the SPL will only update the current version to the target version so we will get this diff:
but the lock file in the SPL has already bumped to 1.18.2. it will make the build failed.
due to 1, I tried to update the patch script to yihau/solana-program-library@d7c17af
it will get the diff look like:
but we still couldn't get it pass due to the borsh version mismatch.
Summary of Changes
I think it should be better to disable SPL downstream test for v1.17 instead of reverting the PR in SPL.