Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17: ensure that SPL downstream tests always succeed #106

Closed
wants to merge 1 commit into from

Conversation

yihau
Copy link
Member

@yihau yihau commented Mar 6, 2024

Problem

SPL repo upgraded their dependencies version to v1.18.2 (solana-labs/solana-program-library#6278). it caused two problems

  1. its patch script won't work with lower version of solana dependencies.

the patch script that is in the SPL will only update the current version to the target version so we will get this diff:

Screenshot 2024-03-03 at 12 48 31

but the lock file in the SPL has already bumped to 1.18.2. it will make the build failed.

  1. borsh version mismatch

due to 1, I tried to update the patch script to yihau/solana-program-library@d7c17af

it will get the diff look like:
Screenshot 2024-03-06 at 17 02 50

but we still couldn't get it pass due to the borsh version mismatch.

Summary of Changes

I think it should be better to disable SPL downstream test for v1.17 instead of reverting the PR in SPL.

@yihau yihau marked this pull request as ready for review March 6, 2024 09:08
@joncinque
Copy link

We could also do what we did for 1.16, and create a 1.17 branch in SPL at the last 1.17 commit, and test downstream jobs against that. What do you think?

@CriesofCarrots
Copy link

We could also do what we did for 1.16, and create a 1.17 branch in SPL at the last 1.17 commit, and test downstream jobs against that.

We did the other thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants