DRAFT: Reduce buffer size of unused side of socket #3618
+419
−116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We allocate large send and receive buffers for all sockets. However, not all sockets read and write to/from the buffers. In fact, 6 sockets are Read Only and 2 are Write Only. Meaning we are allocating memory that is never used.
Summary of Changes
SocketConfig
to use builder patternnet-utils
methods that use defaultSocketConfig
NOTE: i got rid of the default "bind" methods in
net-utils/lib.rs
so that developers are intentional about their socket allocations.Services/Sockets
Read/Write
Read Only
Write Only
Follow Up PR: