Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add better doc comments/warnings for TransactionWithMeta functions #4827

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add better doc comments/warnings for TransactionWithMeta functions #4827

wants to merge 1 commit into from

Conversation

apfitzge
Copy link

@apfitzge apfitzge commented Feb 6, 2025

Problem

  • Not obvious from current comment that you should not use these functions unless necessary.
  • We eventually want to remove these functions once legacy interfaces are fixed

Summary of Changes

  • Add doc comments making clear these functions should not be used.

Fixes #

@apfitzge apfitzge requested a review from a team as a code owner February 6, 2025 14:30
@apfitzge apfitzge mentioned this pull request Feb 6, 2025
Open
@2501babe 2501babe self-requested a review February 6, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2501babe 2501babe 2501babe approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apfitzge @2501babe