Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coinbase Wallet universal links #1016

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ssamkkim
Copy link

@ssamkkim ssamkkim commented Aug 27, 2024

This pr adds universal links to the Coinbase Wallet adapter, allowing IOS browser users to be redirected to their Coinbase Wallet app if it is installed. The code borrows semantics and logic from other wallet adapters that implement universal links such as Phantom and Solflare.

coinbase-wallet-adapter.mov

@ssamkkim ssamkkim changed the title feat: coinbase wallet universal link Coinbase Wallet universal links Aug 27, 2024
Copy link
Collaborator

@mcintyre94 mcintyre94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I haven't tested but the code/logic looks good, and makes sense to add this for Coinbase Wallet.

Could you point me to somewhere in their docs that shows this is the right way to redirect into their app? Just keen to make sure we're using something they properly support here.

@ssamkkim
Copy link
Author

ssamkkim commented Aug 28, 2024

Thanks for this! I haven't tested but the code/logic looks good, and makes sense to add this for Coinbase Wallet.

Could you point me to somewhere in their docs that shows this is the right way to redirect into their app? Just keen to make sure we're using something they properly support here.

Yep, here's the link to the Coinbase Wallet's deep link docs.

It may also be helpful to use the IOS specific redirect URL instead. This video is what that would look like to use that instead of the universal link on the Arc Search IOS mobile browser.

trim.4FEBD101-812E-4D8D-9164-766F5D52C47B.MOV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants