Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reprocessing historical wave data #1142

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ana-berger
Copy link
Contributor

No description provided.

@ana-berger ana-berger requested a review from bpasquer February 16, 2023 01:02
@@ -1,13 +1,13 @@
GitPython==2.0.6
OWSLib
geopy==1.11.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to modify this file, it has it's own requirements.txt file https://github.com/aodn/data-services/blob/master/AODN/AODN-WAVE-DM/requirements.txt

@@ -47,7 +47,7 @@

import numpy as np

from IMOSnetCDF import attributesFromIMOSparametersFile
from python.IMOSnetCDF import attributesFromIMOSparametersFile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break other codes. please revert

@@ -11,13 +11,13 @@
import pandas
import numpy as np
from netCDF4 import Dataset, date2num
from generate_netcdf_att import generate_netcdf_att
from python.generate_netcdf_att import generate_netcdf_att
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This python. should be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the only way it worked on my machine. I am not changing it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on your machine yes maybe, but that's not the way sorry. if this was used on RC or prod, it shouldn't have python.

@ana-berger
Copy link
Contributor Author

This is just for Bene to have the updated code. I am not changing anything as this is the version that worked on my machine. If the working code for reprocessing is to be shared with everyone, that is it. Not doing any work on that anymore

@ana-berger ana-berger marked this pull request as draft February 16, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants