remove DakutenKatakana; use Gaiji with kuten2png #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahashim
force-pushed
the
remove-dakute-katakana
branch
from
2d83077 to
3755ddb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aozora2Html::Tag::DakutenKatakanaクラスですが、実際には普通の外字の扱いを行えばこのクラスは必要ないようなので、クラスごと削除します。（現在Aozora2Html::Tag::DakutenKatakanaを生成しているのは
dispatch_aozora_commandから呼ばれるapply_dakuten_katakanaですが、※で外字を記述する場合はdispatch_aozora_commandの前にdispatch_gaijiが呼ばれてそこで処理されるはずなので、そもそもAozora2Html::Tag::DakutenKatakanaを生成するパスは実行されない？）