Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARTEMIS-4680 - Upgrade the console to use HawtIO 4 #15

Merged
merged 2 commits into from
May 15, 2024

Conversation

andytaylor
Copy link
Contributor

Some general tidying up, adding ids and a few fixes

Copy link

@lavocatt lavocatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me! Checking out this PR gave me the opportunity to run the hawtio console for the first time.

Maybe it would be worth it to split the PR into a few commits though, I feel that there is space for at least one commit for the dependencies update and one commit for the UI fixes.

Some general tidying up, adding ids and a few fixes
@andytaylor
Copy link
Contributor Author

All looks good to me! Checking out this PR gave me the opportunity to run the hawtio console for the first time.

Maybe it would be worth it to split the PR into a few commits though, I feel that there is space for at least one commit for the dependencies update and one commit for the UI fixes.

I have split it into 2 commits as suggested

@gemmellr gemmellr merged commit 2deba43 into apache:main May 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants