ARTEMIS-5142 support never expiring incoming messages #5390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbertram
force-pushed
the
ARTEMIS-5142-alt
branch
from
54c9e9b to
34dba71
Compare
|
@gemmellr, if you're good with this then I'll add more tests for the new |
gemmellr
reviewed
Dec 12, 2024
artemis-server/src/main/resources/schema/artemis-configuration.xsd
Outdated
Show resolved
Hide resolved
...is-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java
Outdated
Show resolved
Hide resolved
jbertram
force-pushed
the
ARTEMIS-5142-alt
branch
from
34dba71 to
1c7165e
Compare
|
You mentioned adding more tests...this is one I actually do think should have integration tests as well. In particular, as I think about it more, I guess its likely there is a gotcha in there for AMQP messages (both for this and the existing min/max etc). I would not be surprised to see the broker apply the new expirations 'locally' but then send the original expiration to the consumer...so e.g if you increase or remove an original expiration, things may not turn out at all as intended. |
jbertram
force-pushed
the
ARTEMIS-5142-alt
branch
from
1c7165e to
a636a41
Compare
|
@gemmellr, I added some integration tests and fixed problem which I found. Let me know what you think. |
gemmellr
reviewed
Dec 16, 2024
...va/org/apache/activemq/artemis/tests/integration/jms/multiprotocol/JMSMessageExpiryTest.java
Outdated
Show resolved
Hide resolved
...va/org/apache/activemq/artemis/tests/integration/jms/multiprotocol/JMSMessageExpiryTest.java
Outdated
Show resolved
Hide resolved
...va/org/apache/activemq/artemis/tests/integration/jms/multiprotocol/JMSMessageExpiryTest.java
Outdated
Show resolved
Hide resolved
...va/org/apache/activemq/artemis/tests/integration/jms/multiprotocol/JMSMessageExpiryTest.java
Outdated
Show resolved
Hide resolved
...va/org/apache/activemq/artemis/tests/integration/jms/multiprotocol/JMSMessageExpiryTest.java
Outdated
Show resolved
Hide resolved
...va/org/apache/activemq/artemis/tests/integration/jms/multiprotocol/JMSMessageExpiryTest.java
Outdated
Show resolved
Hide resolved
jbertram
force-pushed
the
ARTEMIS-5142-alt
branch
6 times, most recently
from
340ec3c to
67a7f00
Compare
jbertram
force-pushed
the
ARTEMIS-5142-alt
branch
from
67a7f00 to
84f4458
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gemmellr, take a look at this as a potential replacement for #5334. I feel like this is much simpler and more intuitive.