ARTEMIS-5215 AMQP federation consumer close can allow duplicates on r… #5401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emote Messages that are in-flight on a link when the federation consumer is closed due to removal of local demand might get enqueued on the local broker but the disposition might not get sent to the remote leading to a release of the message back to the source queue leading to a duplicate being left on the remote. The AMQP receiver links need to be drained and any pending settlements need to be sent before the link can be allowed to be detached.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…emote
Messages that are in-flight on a link when the federation consumer is closed due to removal of local demand might get enqueued on the local broker but the disposition might not get sent to the remote leading to a release of the message back to the source queue leading to a duplicate being left on the remote. The AMQP receiver links need to be drained and any pending settlements need to be sent before the link can be allowed to be detached.