Stringbuffer cleanup part2 (splitted commits) #1471

grigoni · 2025-07-08T04:21:27Z

about StringBuffer usage, this PR splits changes per type and module

use StringBuilder instead of StringBuffer: this avoids unnecessary sync
use StringBuilder best practice when concatenating
avoid concatenation in logging
use java.nio.charset.StandardCharsets for getBytes
use isEmpty() instead of ...length() > 0
use "0123456789".repeat(Math.max(0, loopSize)); instead of a loop with a SB
some typos fixing
see https://issues.apache.org/jira/browse/AMQ-9732

…e-6.0.0

use StringBuilder in method createCompositeDestination instead of basic String concatenation +=

use StringBuilder instead of StringBuffer in loadJmsMessage method

apply best practices in string collation

avoid StringBuffer and use java 11 String#repeat

rewrite some logging to use params instead of concatenation

use StandardCharsets.UTF_8/US_ASCII which is more robust and does not throw UnsupportedEncodingException

remove StringBuffer where no loop is involved since java compiler will optimize better

rewrite some logging to use params instead of concatenation

use StringBuilder in method createCompositeDestination instead of basic String concatenation +=

use StringBuilder instead of StringBuffer in loadJmsMessage method

apply best practices in string collation

avoid StringBuffer and use java 11 String#repeat

rewrite some logging to use params instead of concatenation

use StandardCharsets.UTF_8/US_ASCII which is more robust and does not throw UnsupportedEncodingException

remove StringBuffer where no loop is involved since java compiler will optimize better

rewrite some logging to use params instead of concatenation

Bumps [org.springframework:spring-core](https://github.com/spring-projects/spring-framework) from 6.2.10 to 6.2.11. - [Release notes](https://github.com/spring-projects/spring-framework/releases) - [Commits](spring-projects/spring-framework@v6.2.10...v6.2.11) --- updated-dependencies: - dependency-name: org.springframework:spring-core dependency-version: 6.2.11 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…sage

…aged, and temporary queues and topics (apache#1288) * Add attributes to display total number of queues and topics * Addressed comments and add metrics for temporary queues and topics * Use assertEquals and make the test more accurate * renamed NonSuppreseed to Managed * fixed logic for counting ManagedTopic and ManagedQueue

use StringBuilder in method createCompositeDestination instead of basic String concatenation +=

use StringBuilder instead of StringBuffer in loadJmsMessage method

apply best practices in string collation

avoid StringBuffer and use java 11 String#repeat

rewrite some logging to use params instead of concatenation

use StandardCharsets.UTF_8/US_ASCII which is more robust and does not throw UnsupportedEncodingException

remove StringBuffer where no loop is involved since java compiler will optimize better

rewrite some logging to use params instead of concatenation

…fer_splitted' into feature/cleanup_part2_stringbuffer_splitted

mattrpav and others added 15 commits July 3, 2025 07:22

[AMQ-9737] activemq-spring: Remove references to schema namespaces pr…

5dc9982

…e-6.0.0

use StringBuilder instead of StringBuffer in join method

45be7ef

use StringBuilder in method createCompositeDestination instead of basic String concatenation +=

rewrite some logging to use params instead of concatenation

d22f719

use StringBuilder instead of StringBuffer in loadJmsMessage method

use StringBuilder instead of StringBuffer in validate method

3220a40

use StringBuilder instead of StringBuffer

77b5bf5

apply best practices in string collation

rewrite some logging to use params instead of concatenation

2a38eeb

avoid StringBuffer and use java 11 String#repeat

rewrite some logging to use params instead of concatenation

9b2864e

avoid StringBuffer and use java 11 String#repeat

use StringBuilder instead of StringBuffer

86c7e4e

rewrite some logging to use params instead of concatenation

use StringBuilder instead of StringBuffer

af7caaf

use StringBuilder instead of StringBuffer

1a6e280

use StandardCharsets.UTF_8/US_ASCII which is more robust and does not throw UnsupportedEncodingException

use StringBuilder instead of StringBuffer

a1390ae

remove StringBuffer where no loop is involved since java compiler will optimize better

use StringBuilder instead of StringBuffer

167c8aa

rewrite some logging to use params instead of concatenation

use StringBuilder instead of StringBuffer

dde36ea

avoid StringBuffer and use java 11 String#repeat

9712e8a

use StringBuilder instead of StringBuffer

21b4672

grigoni mentioned this pull request Jul 8, 2025

AMQ-9732: More Code cleanup: use StringBuilder instead of StringBuffer #1461

Open

grigoni changed the title ~~Feature/cleanup part2 stringbuffer splitted~~ Stringbuffer cleanup part2 (splitted commits) Jul 8, 2025

giana added 13 commits July 9, 2025 23:00

use StringBuilder instead of StringBuffer in join method

af147ac

use StringBuilder in method createCompositeDestination instead of basic String concatenation +=

rewrite some logging to use params instead of concatenation

89e2769

use StringBuilder instead of StringBuffer in loadJmsMessage method

use StringBuilder instead of StringBuffer in validate method

a052e40

use StringBuilder instead of StringBuffer

234113a

apply best practices in string collation

rewrite some logging to use params instead of concatenation

3440022

avoid StringBuffer and use java 11 String#repeat

rewrite some logging to use params instead of concatenation

d29677c

avoid StringBuffer and use java 11 String#repeat

use StringBuilder instead of StringBuffer

e968807

rewrite some logging to use params instead of concatenation

use StringBuilder instead of StringBuffer

acc4bd3

use StringBuilder instead of StringBuffer

67c34db

use StandardCharsets.UTF_8/US_ASCII which is more robust and does not throw UnsupportedEncodingException

use StringBuilder instead of StringBuffer

b3e0b09

remove StringBuffer where no loop is involved since java compiler will optimize better

use StringBuilder instead of StringBuffer

677dd18

rewrite some logging to use params instead of concatenation

use StringBuilder instead of StringBuffer

856d802

avoid StringBuffer and use java 11 String#repeat

1342038

jbonofre and others added 28 commits September 25, 2025 07:56

AMQ-9762: Upgrade to Jackson 2.20.0 (apache#1492)

083a30e

AMQ-9766: Upgrade to Jetty 11.0.26 (apache#1488)

0f2eac3

AMQ-9763: Upgrade to commons-io 2.20.0 (apache#1491)

ea5edb5

AMQ-9764: Upgrade to Camel 4.14.0 (apache#1490)

e5c29bd

[AMQ-9768] Fix JMX value escaping in web console. (apache#1487)

f68fff9

[AMQ-9773] Fix for only one message being recovered from backup

ec633b3

[AMQ-9773-b] Update code comments for backup only recoverying one mes…

96c92e4

…sage

AMQ-9718 Removed collections which are never queried (apache#1444)

51553dd

[AMQ-9394] Tech Preview: Virtual Thread support

edd358d

[AMQ-9777] Migrate to using multi-release jar for activemq-client

56ea235

AMQ-9746: Upgrade to Jolokia 2.3.0 (apache#1502)

587bd4f

use StringBuilder instead of StringBuffer in join method

59d7567

use StringBuilder in method createCompositeDestination instead of basic String concatenation +=

rewrite some logging to use params instead of concatenation

aa9bb70

use StringBuilder instead of StringBuffer in loadJmsMessage method

use StringBuilder instead of StringBuffer in validate method

abd6727

use StringBuilder instead of StringBuffer

322ee39

apply best practices in string collation

rewrite some logging to use params instead of concatenation

83e8284

avoid StringBuffer and use java 11 String#repeat

rewrite some logging to use params instead of concatenation

ca3c560

avoid StringBuffer and use java 11 String#repeat

use StringBuilder instead of StringBuffer

9094e01

rewrite some logging to use params instead of concatenation

use StringBuilder instead of StringBuffer

81fe4a4

use StringBuilder instead of StringBuffer

2de1072

use StandardCharsets.UTF_8/US_ASCII which is more robust and does not throw UnsupportedEncodingException

use StringBuilder instead of StringBuffer

ab35359

remove StringBuffer where no loop is involved since java compiler will optimize better

use StringBuilder instead of StringBuffer

03c707e

rewrite some logging to use params instead of concatenation

use StringBuilder instead of StringBuffer

5497d93

avoid StringBuffer and use java 11 String#repeat

b324282

use StringBuilder instead of StringBuffer

16aa5af

Merge remote-tracking branch 'grigoni/feature/cleanup_part2_stringbuf…

2674b36

…fer_splitted' into feature/cleanup_part2_stringbuffer_splitted

grigoni closed this Oct 5, 2025

grigoni deleted the feature/cleanup_part2_stringbuffer_splitted branch October 5, 2025 16:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Stringbuffer cleanup part2 (splitted commits) #1471

Stringbuffer cleanup part2 (splitted commits) #1471

Uh oh!

grigoni commented Jul 8, 2025

Uh oh!

Uh oh!

Stringbuffer cleanup part2 (splitted commits) #1471

Stringbuffer cleanup part2 (splitted commits) #1471

Uh oh!

Conversation

grigoni commented Jul 8, 2025

Uh oh!

Uh oh!