Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JaasAuthenticationBroker.java #710

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update JaasAuthenticationBroker.java #710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions activemq-broker/src/main/java/org/apache/activemq/security/JaasAuthenticationBroker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import java.security.Principal;
import java.security.cert.X509Certificate;
import java.util.Properties;
import java.util.Set;

import javax.security.auth.Subject;
Expand All @@ -26,6 +27,7 @@
import org.apache.activemq.broker.Broker;
import org.apache.activemq.broker.ConnectionContext;
import org.apache.activemq.command.ConnectionInfo;
import org.apache.activemq.jaas.EncryptionSupport;
import org.apache.activemq.jaas.JassCredentialCallbackHandler;

/**
Expand Down Expand Up @@ -86,6 +88,10 @@ public void addConnection(ConnectionContext context, ConnectionInfo info) throws
@Override
public SecurityContext authenticate(String username, String password, X509Certificate[] certificates) throws SecurityException {
SecurityContext result = null;
Properties prop = new Properties();
prop.put(username, password);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix inconsistent spacing

EncryptionSupport.decrypt(prop);
password = prop.getProperty(username);
JassCredentialCallbackHandler callback = new JassCredentialCallbackHandler(username, password);
try {
LoginContext lc = new LoginContext(jassConfiguration, callback);
Expand Down