-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FirstMessageAge and FirstMessageTimestamp JMX metrics for queues. #839
base: main
Are you sure you want to change the base?
Add FirstMessageAge and FirstMessageTimestamp JMX metrics for queues. #839
Conversation
ref: https://issues.apache.org/jira/browse/AMQ-8463 I'd like to review the naming here, given the plans to add additional metrics. We should have it all align. Metrics:
|
Initially the idea was to call it oldestMessageAge or ageOfOldestMessage, but then I came across the artemis metric and decided to use the same name for the sake of consistency. |
The change looks good to me. I think using I will resume my work on this one (spinning another one). |
I think this approach is incorrect, and we should revisit the approach in 6.1.0 |
We will see later but I will probably close this PR with a new one for 6.1.0 with a different impl. |
This change is meant to match the piece of functionality from Artemis: apache/activemq-artemis@00837c1
Add two new JMX attributes for queues: FirstMessageAge and FirstMessageTimestamp.
First one shows the diff between current time and the message timestamp of the first message in the queue.
Second one shows the message timestamp of the first message in the queue.