Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error with PG17 palloc0fast compilation #2118

Closed
wants to merge 1 commit into from

Conversation

uhayat
Copy link
Contributor

@uhayat uhayat commented Sep 25, 2024

In PG17 palloc0fast is removed and palloc0 is instead

@shinyaaa
Copy link
Contributor

I think that change is correct.
However, in this project, the condition by PG_VERSION_NUM may be unnecessary, as the branches are separated by PG version.
(I don't know how to do this, as the PG17 branch has not yet been created.)

@jrgemignani
Copy link
Contributor

@uhayat I am okay with merging a change where palloc0fast is replaced by palloc0. But, we don't use version flags as stated by @shinyaaa above, so I won't approve that.

In PG17 palloc0fast is removed and palloc0 is instead
@uhayat
Copy link
Contributor Author

uhayat commented Sep 27, 2024

@jrgemignani understood. I updated the commit and removed the version check.

@uhayat
Copy link
Contributor Author

uhayat commented Oct 27, 2024

Anybody available for review ?

@jrgemignani
Copy link
Contributor

@uhayat See #2111 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants