-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: task flow dynamic mapping with default_args #41592
Merged
Merged
+42
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phi-friday
force-pushed
the
fix-task-flow-dynamic-mapping
branch
from
August 19, 2024 23:50
9ab775d
to
0ca9fcd
Compare
uranusjr
reviewed
Aug 20, 2024
phi-friday
force-pushed
the
fix-task-flow-dynamic-mapping
branch
from
August 20, 2024 10:36
0ca9fcd
to
1587f74
Compare
uranusjr
reviewed
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, otherwise looks good to me
uranusjr
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough for me
phi-friday
force-pushed
the
fix-task-flow-dynamic-mapping
branch
from
August 26, 2024 03:20
de3f1a2
to
a91b7b3
Compare
phi-friday
force-pushed
the
fix-task-flow-dynamic-mapping
branch
from
September 5, 2024 12:07
a91b7b3
to
fd84926
Compare
phi-friday
force-pushed
the
fix-task-flow-dynamic-mapping
branch
2 times, most recently
from
September 15, 2024 07:29
4b78351
to
d9c9f2a
Compare
After a recent rebase, I'm getting the following error, and I'm not sure why. _________ TestOtelMetrics.test_timer_start_and_stop_manually_send_true _________
[gw2] linux -- Python 3.8.20 /usr/local/bin/python
self = <tests.core.test_otel_logger.TestOtelMetrics object at 0x7f0c14b7e370>
mock_time = <MagicMock name='perf_counter' id='139690224843072'>
name = 'test_stats_run'
@mock.patch.object(time, "perf_counter", side_effect=[0.0, 3.14])
def test_timer_start_and_stop_manually_send_true(self, mock_time, name):
timer = self.stats.timer(name)
timer.start()
# Perform some task
timer.stop(send=True)
assert isinstance(timer.duration, float)
> assert timer.duration == 3.14
E assert 3140.0 == 3.14
E + where 3140.0 = <airflow.metrics.otel_logger._OtelTimer object at 0x7f0c2a6999a0>.duration
tests/core/test_otel_logger.py:327: AssertionError |
phi-friday
force-pushed
the
fix-task-flow-dynamic-mapping
branch
2 times, most recently
from
September 18, 2024 16:59
0a79c1a
to
d42437e
Compare
phi-friday
force-pushed
the
fix-task-flow-dynamic-mapping
branch
from
September 21, 2024 09:55
d42437e
to
030f7d0
Compare
potiuk
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #33600
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.