apply otel_service on metrics #42242
Open
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Running this test in main, and it failed with the same error:
Maybe @ferruzzi can help us figure it out? |
|
This PR: #42267 should fix the current failed tests |
romsharon98
force-pushed
the
fix/otel-service-name
branch
from
40274be
to
aa9d187
Compare
Yeah, looks like you got it sorted out. Looks like it was a side-effect of the PR which converted reporting timers from seconds to millis, |
eladkal
reviewed
Sep 20, 2024
airflow/config_templates/config.yml
Outdated
| otel_service: | ||
| description: | | ||
| The default service name of traces. | ||
| version_added: 2.10.1 |
There was a problem hiding this comment.
needs to update to 2.10.3 and confirm with @ephraimbuddy that this PR is for bugfix release otherwise it must be 2.11
There was a problem hiding this comment.
changed for 2.10.3
romsharon98
added
type:bug-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #42210
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.