Simple auth manager documentation #42390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
requested review from
eladkal,
o-nikolas and
potiuk
as code owners
boring-cyborg
bot
added
area:providers
kind:documentation
provider:amazon-aws
|
Fails in static checks |
o-nikolas
reviewed
Sep 23, 2024
|
It seems modifying docs from Airflow core and providers at the same time is challenging for the CI. It is complaining some document do not exist but they do (in the PR). Therefore, I created a PR for Airflow core only: #42418. Once this one is merged, I'll create another one for providers |
vincbeck
force-pushed
the
vincbeck/simple_auth_manager_doc
branch
from
3c5f41a
to
655c332
Compare
vincbeck
force-pushed
the
vincbeck/simple_auth_manager_doc
branch
from
655c332
to
abd2481
Compare
|
CI is green. I ended up removing references to Airflow core documentation from providers. Somehow, the CLI was complaining it could not find a page ... that exists |
o-nikolas
approved these changes
Sep 23, 2024
shahar1
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create documentation for simple auth manager.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.