-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add on_kill equivalent to Databricks SQL Hook to cancel timed out queries #42668
Add on_kill equivalent to Databricks SQL Hook to cancel timed out queries #42668
Conversation
457a345
to
5a01d2a
Compare
This reverts commit 13287fcc63cfe2f3df548c287bd6386007520167.
5a01d2a
to
75f8c05
Compare
@Lee-W - Could you help me understand why the new exceptions are not being found in
The exceptions are present in the file and are able to be successfully imported locally when I run
Also, the DB tests seem to be failing because of tests unrelated to my changes, or I'm missing how they are connected. |
LGTM |
hey @uranusjr - Can you please review as your requested changes should be addressed now? 🙏 |
Wanted to nudge on this again. @uranusjr - Is there any timeline for when you could re-review? |
The Databricks Provider did not implement a mechanism to cancel SQL queries submitted by DatabricksSqlHook. This led to data quality issues, where Airflow would report a cancellation due to timeout; however, the corresponding SQL query would continue to run on Databricks.
This PR uses threading to cancel SQL queries submitted by DatabricksSqlHook.run() once the timeout is exceeded.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.