Refactor SerializedDagModel and DagCode for dag versioning #43821
+120
−218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
requested review from
pierrejeambrun,
potiuk,
jedcunningham,
XD-DENG and
ashb
as code owners
boring-cyborg
bot
added
area:API
ephraimbuddy
force-pushed
the
versioning-refactor
branch
2 times, most recently
from
2bfd429
to
328f018
Compare
Now that we have dag versioning, the SerializedDagModel and DagCode objects should no longer be deleted. Deletion should start with the DagModel, which will cascade to the DagVersion, then to the DagCode and SerializedDagModel. Also, these models are no longer updated. Instead, a new object is added; hence, the last_updated is changed to created_at.
ephraimbuddy
force-pushed
the
versioning-refactor
branch
from
328f018
to
33f09ad
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have dag versioning, the SerializedDagModel and DagCode objects should no longer be deleted. Deletion should start with the DagModel, which will cascade to the DagVersion, then to the DagCode and SerializedDagModel.
Also, these models are no longer updated. Instead, a new object is added; hence, the last_updated is changed to created_at.