fix(proivders/common/compat): move airflow versions out of __init__.py

[Lee-W]

Why

#43773 (comment)

What

compare airflow versions in each modules

---

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[potiuk]

This is, unfortunately, not a complete solution.

If we want to move those thing to "versions" in common.compat we also need to import those in all providers that use it, and add provider.yaml dependency to this new (not yet released) feature of common.compat.

and after discussion with @dstandish - I am not sure we want to do it. I think we should agree what to do and how to approach it consistently (and also have it described somewhere - how we are doing it.

Daniel in slack discussion raised concerns about dependencies introduced this way - for example this one introduced dependency on specific common-compat version in providers using it (which BTW. should be added in provider.yaml if we want to depend on this common.compat package.)

And yes I agree having just import of the constant requiring to have "common.compat" dependency is excessive.

So I think it would be great if we agree @dstandish @uranusjr @Lee-W @eladkal - from people involved in the discussiosn what we do - before we do it.

Because it has some questions/ answers:

• tests_common has currently the same named constants and it already caused confusion - worth renaming those ?
• we miss common.compat dependency to the upcoming version of common.compat - each provider using those constants has to have common.compat >= NEW_VERSION ?
• are we going to have 2.11 as well in the list of constants below for the future?
• maybe it's better to copy*paste the - currently DRY - code to all providers rather than have this common code at all?

Those were all the questions that need some answers and consensus, so that we are all on the same page and can guide contributors and commiters how to add this compatiblity code.

[potiuk]

Also see #44607 as potential long-term solution (some 8 months from now).

[dstandish]

yeah i think ultimately these constants to more harm than good.

i think we should just chop em. it's more readable to just do something like this example

        if _get_airflow_version() >= Version("2.11.0"):
            timeout = self.timeout
        else:
            timeout = timedelta(seconds=self.timeout)

it's simple, it's explicit, it does not require any constants to be defined.

wherever we have constants like this defined, we can add a single private helper function

def _get_airflow_version():
    from airflow import __version__ as airflow_version

    return Version(Version(airflow_version).base_version)

then when the min airflow version of the provider reaches 2.11, we can use the helper from core introduced in #44607

wdyt

[dstandish]

and to clarify, i think it's fine to have these defined in test utils --- that i think doesn't really matter because there's no cross-provider dep issue. but for non-test code i think we do not add such constants, except possibly locally / privately for convenience -- in which case doesn't really bother me.

[Lee-W]

Got it. Yep, sounds good to me! I thought we needed a hotfix for it. I'll change it later today!

[Lee-W]

I just tried to change it to a similar approach. we probably will need it before min airflow version set to 2.11

[potiuk]

I will come up with alternative proposal soon :)

[potiuk]

Better and more complete ("eat cake and have it too") in #44686