Extract version compatibility constant in tests to version_compat #44770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
mobuchowski,
eladkal and
o-nikolas
as code owners
boring-cyborg
bot
added
area:logging
area:providers
provider:amazon
gopidesupavan
approved these changes
Dec 8, 2024
potiuk
force-pushed
the
move-version-constants-to-version-compat
branch
from
c17ef77 to
0bcd8f0
Compare
This is extracted out of apache#44686 - pre-requisite for consistency check and consistency change to always use version_compat embedded in providers and avoid mistakes with importing the compat from tests in the providers code. This is purely extraction of constants that use to be in compat module to version_compat - which will make it easy to write the pre-commit to check if version_compat from tests_modules is used accidentally.
potiuk
force-pushed
the
move-version-constants-to-version-compat
branch
from
0bcd8f0 to
f9373f9
Compare
hussein-awala
approved these changes
Dec 8, 2024
jscheffl
approved these changes
Dec 8, 2024
|
Interestingly enough - that one got a conversation started by someone who has been apparently malicious user and deleted since ... And I cannot merge it as the conversation is gone. I will raise the issue to Github and open a new PR. |
|
@hussein-awala @gopidesupavan @jscheffl -> #44774 kind request to transfer your approvals there :) |
|
Ticket created in Github Support: https://support.github.com/ticket/personal/0/3130863 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extracted out of #44686 - pre-requisite for consistency check and consistency change to always use version_compat embedded in providers and avoid mistakes with importing the compat from tests in the providers code.
This is purely extraction of constants that use to be in compat module to version_compat - which will make it easy to write the pre-commit to check if version_compat from tests_modules is used accidentally.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.