Add pre-commit To Prevent Usage of session.query #47275
Open
+111
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
I will raise a PR soon for removing |
Prab-27
force-pushed
the
add-pre-commit-to-prevent-usage-session.query
branch
from
5d4d4dc to
b6775a8
Compare
ephraimbuddy
reviewed
Mar 4, 2025
| language: python | ||
| additional_dependencies: ['rich>=12.4.4'] | ||
| files: ^airflow.*\.py$|^task_sdk.*\.py | ||
| exclude: ^tests/.*\.py$|^task_sdk/tests/.*\.py$ |
There was a problem hiding this comment.
Suggested change
| exclude: ^tests/.*\.py$|^task_sdk/tests/.*\.py$ |
Since we have given it specific files to check, do we still need to exclude others?
You can do it in this PR. This PR should raise and point to where there are usages of session.query |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes : #45461
Introduce a pre-commit hook to prevent the use of session.query in the core Airflow code.
This is limited to the source code and excludes the tests/ package.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.