Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IVY-1280 Support preemptive authentication #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

twogee
Copy link
Contributor

@twogee twogee commented Feb 1, 2018

I adopted a patch by @AurelienLourot

@lourot
Copy link

lourot commented Feb 1, 2018

Note that I didn't push it upstream because of this open point: tt-gf#2 (comment)

So this might break some authentication schemes, I'm not really sure.

EDIT: we have been using it at TomTom for a while, but we use only the Basic auth scheme.

@twogee
Copy link
Contributor Author

twogee commented Feb 1, 2018

I have noticed that. Perhaps it's enough to document that preemptive authentication only works with basic scheme.

@twogee
Copy link
Contributor Author

twogee commented Feb 1, 2018

Looking at examples, digest authentication uses the same cache, only sets a different scheme.

@twogee twogee force-pushed the ivy-1280 branch 2 times, most recently from 18c4efc to a9139f0 Compare March 3, 2018 11:23
@twogee twogee force-pushed the ivy-1280 branch 4 times, most recently from 279cacf to 6745ae2 Compare March 15, 2018 18:54
@twogee
Copy link
Contributor Author

twogee commented Mar 15, 2018

I would like to add the preemptive authentication flag to the newly minted TimeoutConstrainedURLHandler to avoid BWC issues. Any objections, @jaikiran ?

@twogee
Copy link
Contributor Author

twogee commented Mar 17, 2018

@AurelienLourot we moved the discussion to JIRA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants