Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AntClassLoader.java #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

majkelBB
Copy link

@majkelBB majkelBB commented Nov 8, 2019

Shouldn't usage of pathComponents be threadsafe here and in other places where code iterates over pathComponents?

Shouldn't usage of pathComponents be threadsafe here and in other places where code iterates over pathComponents?
@asf-ci
Copy link

asf-ci commented Nov 8, 2019

Can one of the admins verify this patch?

1 similar comment
@asf-ci
Copy link

asf-ci commented Nov 8, 2019

Can one of the admins verify this patch?

@jaikiran
Copy link
Member

this is ok to test

@asf-ci
Copy link

asf-ci commented Nov 11, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Linux/147/

@asf-ci
Copy link

asf-ci commented Nov 11, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows/153/

@bodewig
Copy link
Member

bodewig commented Nov 11, 2019

The way AntClassLoader wants to be used (and is used inside of Ant's codebase) is a single-threaded setup phase followed by potentially multithreaded use of if where its setup is no longer changed.

Personally I'd rather document this than try to sprinkle in a few synchronizeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants