Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable route's export OpenAPI func #2802

Merged
merged 3 commits into from
May 10, 2023

Conversation

guoqqqi
Copy link
Member

@guoqqqi guoqqqi commented May 10, 2023

Please answer these questions before submitting a pull request, or your PR will get closed.

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

The export openapi func doesn't work well, we need to disable it for now. This PR disables the frontend section.

refer backend PR: #2801

Related issues

fix/resolve #1

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@guoqqqi guoqqqi changed the title fix: disable route's export OpenAPI func feat: disable route's export OpenAPI func May 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Merging #2802 (7efec30) into master (8390d3d) will increase coverage by 1.52%.
The diff coverage is 100.00%.

❗ Current head 7efec30 differs from pull request most recent head f314fcd. Consider uploading reports for the commit f314fcd to get more accurate results

@@            Coverage Diff             @@
##           master    #2802      +/-   ##
==========================================
+ Coverage   68.61%   70.13%   +1.52%     
==========================================
  Files         139      136       -3     
  Lines        3769     3663     -106     
  Branches      883      876       -7     
==========================================
- Hits         2586     2569      -17     
+ Misses       1183     1094      -89     
Flag Coverage Δ
frontend-e2e-test 70.13% <100.00%> (+1.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/pages/Route/List.tsx 82.66% <ø> (+24.18%) ⬆️
web/src/pages/Route/service.ts 83.87% <100.00%> (+5.08%) ⬆️

... and 28 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@guoqqqi guoqqqi merged commit 764a04e into apache:master May 10, 2023
@guoqqqi guoqqqi deleted the disable-export-route branch May 10, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants