-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow special characters in uri params #11788
fix: allow special characters in uri params #11788
Conversation
@shreemaan-abhishek lint issue |
I tested this change and it doesn't seem to work for In my opinion we should add more test cases for different special characters. I ran some local test on a subset of URL-encoded special characters with
|
@mikyll, this is expected behaviour as route uri: If |
@shreemaan-abhishek thank you for the reply, but I think you misunderstand my previous comment... I agree that Currently, APISIX with This PR fixed the problem for many special characters but not for Please see issue #11810 for further information. |
Description
The underlying
lua-resty-radixtree
library used a regex that would cause route matching to fail when there are special characters in the uri parameters. This has been fixed in the radixtree router library, so we upgrade the version and add a test case that ensures special characters are allowed in uri parameters when usingradixtree_uri_with_parameter
.Checklist