[ARIES-1816] Unable to use <null> with generic arguments

git-svn-id: https://svn.apache.org/repos/asf/aries/trunk@1834984 13f79535-47bb-0310-9956-ffa450edef68
apache · Jul 3, 2018 · f106a19 · f106a19
1 parent dc04d12
commit f106a19
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/...blueprint-core/src/main/java/org/apache/aries/blueprint/utils/generics/TypeInference.java b/...blueprint-core/src/main/java/org/apache/aries/blueprint/utils/generics/TypeInference.java
@@ -281,7 +281,7 @@ private static <E> Match<E> match(Executable<E> executable, List<TypedObject> ar
             TypedObject arg = args.get(i);
             Type needed = parameterTypes[i];
             long sc;
-            if (needed == arg.type) {
+            if (arg.type == null || needed == arg.type) {
                 sc = COST_ASSIGN;
             } else if (allowCast && ClassUtil.getClass(needed).isAssignableFrom(ClassUtil.getClass(arg.type))) {
                 sc = COST_CAST;

diff --git a/.../blueprint-core/src/test/java/org/apache/aries/blueprint/container/TypeInferenceTest.java b/.../blueprint-core/src/test/java/org/apache/aries/blueprint/container/TypeInferenceTest.java
@@ -19,6 +19,7 @@
 package org.apache.aries.blueprint.container;
 
 import org.apache.aries.blueprint.TestBlueprintContainer;
+import org.apache.aries.blueprint.di.ExecutionContext;
 import org.apache.aries.blueprint.pojos.DummyServiceTrackerCustomizer;
 import org.apache.aries.blueprint.pojos.PojoA;
 import org.apache.aries.blueprint.utils.generics.OwbParametrizedTypeImpl;
@@ -31,6 +32,8 @@
 import java.lang.reflect.Constructor;
 import java.lang.reflect.Type;
 import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
 
 import static org.junit.Assert.assertNotNull;
 
@@ -70,11 +73,31 @@ public void testReorder() {
         assertNotNull(match);
     }
 
+    @Test
+    public void testParameterWithNullCollections() {
+        BlueprintContainerImpl container = new BlueprintContainerImpl(null, null, null, null, null, null, null, null, null, null);
+        BeanRecipe recipe = new BeanRecipe("sessionDef", container, FactoryWithList.class, false, false, false);
+        recipe.setArguments(Collections.singletonList(null));
+        recipe.setArgTypes(Collections.<String>singletonList(null));
+        recipe.setFactoryMethod("init");
+        ExecutionContext.Holder.setContext(new BlueprintRepository(container));
+        recipe.create();
+    }
+
     class TIConverter implements TypeInference.Converter {
         public TypeInference.TypedObject convert(TypeInference.TypedObject from, Type to) throws Exception {
             Object arg = from.getValue();
             arg = converter.convert(arg, new GenericType(to));
             return new TypeInference.TypedObject(to, arg);
         }
     }
+
+    public static class FactoryWithList {
+
+        public static String init(List<Integer> ints) {
+            return "Hello!";
+        }
+
+    }
+
 }