Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARIES-2162: Add jmx and blueprint workflows #297

Merged
merged 4 commits into from
Dec 7, 2024

Conversation

alien11689
Copy link
Contributor

No description provided.

@alien11689 alien11689 force-pushed the add-jmx-build-workflow branch 2 times, most recently from 8382fba to fc264cf Compare November 29, 2024 14:02
@alien11689 alien11689 force-pushed the add-jmx-build-workflow branch 2 times, most recently from 1b4a95a to c28e364 Compare November 29, 2024 17:15
@alien11689 alien11689 force-pushed the add-jmx-build-workflow branch from 574b403 to 62fca6e Compare December 1, 2024 09:21
@alien11689 alien11689 changed the title Add jmx build workflow Add jmx and blueprint workflows Dec 2, 2024
@alien11689 alien11689 force-pushed the add-jmx-build-workflow branch from 3bbfa2e to 5016f86 Compare December 2, 2024 15:27
@alien11689 alien11689 force-pushed the add-jmx-build-workflow branch from 5016f86 to 4ad4d27 Compare December 2, 2024 15:33
@alien11689 alien11689 changed the title Add jmx and blueprint workflows ARIES-2162: Add jmx and blueprint workflows Dec 2, 2024
@@ -24,7 +24,7 @@
<parent>
<groupId>org.apache.aries.jmx</groupId>
<artifactId>org.apache.aries.jmx.parent</artifactId>
<version>1.1.6-SNAPSHOT</version>
<version>1.1.5</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, why did you switch back to a release version for this module?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parent artifact has its parent updated (by you in #295 ) and I tested it during creation of workflows.
My goal is to prepare green workflows before making any changes, so the solution may not be perfect but... it works :)
Without changing the version here to the last published version there are test errors in itest:

java.lang.ClassNotFoundException: org.osgi.jmx.framework.*

I wrote about the root reason in #296 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I missed that this is about the parent pom, sorry. So no concerns here.

Final comment from me - would it make sense to build the whole reactor instead of all the ITs and dependant projects?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not able to force jmx/jmx-whiteboard to pass tests in reactor from zero:

  1. current code has problems to fetch artifacts because of http addresses
  2. With upgraded parent, pax url and added javax.inject the code compiles but tests failes and btw artifacts are downloaded via https so...
  3. when removing upgrades and running build again the tests passes

I think that many other tests needs changes for new parent :(

For your @rombert tests it should be fine to add new tests to itest and -am option should include your new bundle build and test.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thank you.

@alien11689 alien11689 merged commit d23d9ec into trunk Dec 7, 2024
8 checks passed
@alien11689 alien11689 deleted the add-jmx-build-workflow branch December 7, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants