Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(go/adbc): bump github.com/snowflakedb/gosnowflake from 1.12.0 to 1.12.1 in /go/adbc #2360

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 9, 2024

Bumps github.com/snowflakedb/gosnowflake from 1.12.0 to 1.12.1.

Release notes

Sourced from github.com/snowflakedb/gosnowflake's releases.

Release

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from zeroshade as a code owner December 9, 2024 20:32
@dependabot dependabot bot added dependencies Dependabot-only go Pull requests that update Go code labels Dec 9, 2024
@github-actions github-actions bot added this to the ADBC Libraries 16 milestone Dec 9, 2024
@lidavidm
Copy link
Member

@dependabot rebase

Bumps [github.com/snowflakedb/gosnowflake](https://github.com/snowflakedb/gosnowflake) from 1.12.0 to 1.12.1.
- [Release notes](https://github.com/snowflakedb/gosnowflake/releases)
- [Changelog](https://github.com/snowflakedb/gosnowflake/blob/master/release.go)
- [Commits](snowflakedb/gosnowflake@v1.12.0...v1.12.1)

---
updated-dependencies:
- dependency-name: github.com/snowflakedb/gosnowflake
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/go/adbc/github.com/snowflakedb/gosnowflake-1.12.1 branch from 85c726c to a4c9137 Compare December 10, 2024 00:37
@lidavidm
Copy link
Member

This needs manual intervention

@lidavidm
Copy link
Member

@zeroshade seems all the ingest tests are failing with Error message: [Snowflake] io: read/write on closed pipe, any clue? Looks like this patch version bump may not be so minor :/

@zeroshade
Copy link
Member

@lidavidm I'll take a look and see what I can figure out

@zeroshade
Copy link
Member

@lidavidm I'm still not precisely sure what change in the snowflake driver caused it to actually hit the problem, but this looks like it's definitely an issue on our end. Possibly even the source of some of the other ingestion problems we were seeing. I've pushed a fix that worked locally, let's see if that's sufficient via the CI

@lidavidm
Copy link
Member

Seems like that did it, thanks!

@lidavidm lidavidm merged commit 46f7a84 into main Dec 10, 2024
74 checks passed
@lidavidm lidavidm deleted the dependabot/go_modules/go/adbc/github.com/snowflakedb/gosnowflake-1.12.1 branch December 10, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependabot-only go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants