Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(c): don't use sketchy cast to test backwards compatibility #2425

Merged
merged 4 commits into from
Jan 9, 2025
Merged

test(c): don't use sketchy cast to test backwards compatibility #2425

merged 4 commits into from
Jan 9, 2025

Conversation

lidavidm
Copy link
Member

@lidavidm lidavidm commented Jan 9, 2025

  • Backport nanoarrow patch to satisfy newer Clang
  • Add test using GCC 15
  • Update tests using sketchy casts to satisfy these compilers
  • Refactor the clang/gcc Docker jobs

Fixes #2424.

@lidavidm
test(c): don't use sketchy cast to test backwards compatibility
4577844 
- Backport nanoarrow patch to satisfy newer Clang
- Add test using GCC 15
- Update tests using sketchy casts to satisfy these compilers
- Refactor the clang/gcc Docker jobs

Fixes apache#2424.
@lidavidm
fix
f9e0bd0
@lidavidm lidavidm marked this pull request as ready for review January 9, 2025 01:24
@lidavidm lidavidm requested review from kou and zeroshade as code owners January 9, 2025 01:24
kou
kou reviewed Jan 9, 2025
View reviewed changes
docker-compose.yml
cpp-gcc-latest:
build:
context: .
dockerfile: ci/docker/cpp-gcc-latest.dockerfile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...doh

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, sorry

paleolimbot
paleolimbot approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

kou
kou approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

https://github.com/apache/arrow-adbc/actions/runs/12683382101/job/35350360844?pr=2425 passed.

@lidavidm lidavidm merged commit 63bb903 into apache:main Jan 9, 2025
71 of 72 checks passed
@lidavidm lidavidm deleted the gh-2424 branch January 9, 2025 06:14
davidhcoe pushed a commit to davidhcoe/arrow-adbc that referenced this pull request Jan 10, 2025
Revert "test(c): don't use sketchy cast to test backwards compatibili…
cd23a21 
…ty (apache#2425)"

This reverts commit 63bb903.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

@paleolimbot paleolimbot paleolimbot approved these changes

@zeroshade zeroshade Awaiting requested review from zeroshade zeroshade is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

c: error: allocation of insufficient size with GCC 14
3 participants
@lidavidm @kou @paleolimbot