Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go/adbc/driver/flightsql): Parsing column metadata in FlightSQL driver #2481

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
+718 −304
Open

fix(go/adbc/driver/flightsql): Parsing column metadata in FlightSQL driver #2481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
3219bd7
fix(go/adbc/driver): implement parsing metadata of mysql. refactored …
xborder Jan 21, 2025
5c12c3e
chore(go/adbc/driver/flightsql): parsing ARROW:FLIGHT:SQL:IS_AUTO_INC…
xborder Jan 21, 2025
84bfe89
chore(go/adbc/driver/flightsql): appending null when strconv fails
xborder Jan 21, 2025
2a795ef
refactor(go/adbc/driver): removed commented code
xborder Jan 21, 2025
d6d6a27
refactor(go/adbc/driver): moved validation tests closer to drivers to…
xborder Jan 21, 2025
bc8ebfc
refactor(go/adbc/driver): move columnxdbc test to validation.go
xborder Jan 21, 2025
54af339
test(go/adbc/driver): temp. trying to get test to work
xborder Jan 21, 2025
32410c3
Revert "test(go/adbc/driver): temp. trying to get test to work"
xborder Jan 21, 2025
898a942
Revert "refactor(go/adbc/driver): move columnxdbc test to validation.go"
xborder Jan 21, 2025
13f07ab
test(go/adbc/driver): adding test to GetObjects
xborder Jan 22, 2025
4c1b477
test(go/adbc/driver): re-enable tests
xborder Jan 22, 2025
e86daf0
fix(go/adbc/driver/flightsql): converting flight sql scopes and data …
xborder Jan 22, 2025
80a80f5
test(go/adbc/driver/flightsql): appending col name to all results to …
xborder Jan 22, 2025
79a4c9b
Revert "refactor(go/adbc/driver): moved validation tests closer to dr…
xborder Jan 22, 2025
c710d8f
chore(go/adbc/driver): Remove unused Metadata struct
xborder Jan 23, 2025
dbe091a
test(go/adbc/driver/flightsql): replace sorting with ElementsMatch
xborder Jan 23, 2025
5c9e494
chore(go/adbc/driver): replaced metadatahandlers with builder that im…
xborder Jan 23, 2025
4b0e812
chore(go/adbc/driver): override SetMetadata for flight
xborder Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/adbc/driver/bigquery/connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ func (c *connectionImpl) GetTablesForDBSchema(ctx context.Context, catalog strin
if err != nil {
return nil, err
}
xdbcDataType := driverbase.ToXdbcDataType(field.Type)
xdbcDataType := internal.ToXdbcDataType(field.Type)

columns = append(columns, driverbase.ColumnInfo{
ColumnName: fieldschema.Name,
Expand Down
Loading
Loading