feat: Check flags field of ArrowSchema on ArrowSchemaViewInit #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
==========================================
- Coverage 87.92% 87.88% -0.04%
==========================================
Files 76 76
Lines 13353 13367 +14
==========================================
+ Hits 11740 11748 +8
- Misses 1613 1619 +6 ☔ View full report in Codecov by Sentry. |
paleolimbot
force-pushed
the
unknown-flags
branch
from
639a8a4 to
3db47c2
Compare
|
Overall LGTM! Just a few small questions not related to correctness. |
danepitkin
reviewed
Jan 26, 2024
src/nanoarrow/schema.c
Outdated
| ArrowSchemaViewValidate(schema_view, schema_view->type, error)); | ||
| } | ||
|
|
||
| int64_t unknown_flags = schema->flags & ~ARROW_FLAG_DICTIONARY_ORDERED & |
There was a problem hiding this comment.
Would this be better as a macro or #define that is defined next to these other #defines? From a maintenance perspective, I'm mainly considering what happens if someone adds a new flag and forgets to update this part of the code.
src/nanoarrow/schema_test.cc
Outdated
| "ARROW_FLAG_MAP_KEYS_SORTED is only relevant for a map type"); | ||
|
|
||
| schema.flags = 0; | ||
| schema.flags |= (ARROW_FLAG_MAP_KEYS_SORTED << 1); |
There was a problem hiding this comment.
We could use the new macro/define here to guarantee we always get an undefined value.
|
✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #312.
ArrowSchemaViewInit()is called every time a schema is about to be interpreted (or an array corresponding to that schema is about to be interpreted), and so checking the flags is a must to ensure some future unsupported flag that affects the interpretation of an array will cause an error.The
ArrowSchemaViewshould arguably also keep track offlags(or perhaps each flag individually), but I will leave that to another PR.