Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace CHANGELOG generator #369

Merged
merged 8 commits into from
Jan 26, 2024

Conversation

paleolimbot
Copy link
Member

Closes #310.

Basically cz ch was constantly doing the wrong thing...for the last two releases I had to do quite a lot of manual editing after it was run. The Python script that replaces it:

  • Can run more than once (replaces the target version's updates if commits were added)
  • Groups components (e.g., so I can copy/paste the R NEWS more readily)
  • Knows about when nanoarrow considers the last version "released"

@paleolimbot paleolimbot marked this pull request as ready for review January 24, 2024 13:30
@lidavidm
Copy link
Member

Hmm, ADBC might want to borrow this too.

Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks like a neat addition, thanks for adding the tests. At the moment the tests are not run in CI right? (or are they part of pre-commit?)

@paleolimbot
Copy link
Member Author

Thanks for taking a look!

At the moment the tests are not run in CI right?

They aren't, but this script also doesn't see many or any changes and is run once every few months. The hard part is writing them!

@paleolimbot paleolimbot merged commit c387134 into apache:main Jan 26, 2024
@paleolimbot paleolimbot deleted the release-improve branch January 26, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix changelog generation
3 participants