Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add basic benchmark setup #384

Merged
merged 9 commits into from
Feb 13, 2024

Conversation

paleolimbot
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a41fb2b) 87.89% compared to head (8d7fd28) 87.89%.
Report is 1 commits behind head on main.

Files Patch % Lines
r/R/buffer.R 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #384   +/-   ##
=======================================
  Coverage   87.89%   87.89%           
=======================================
  Files          76       76           
  Lines       13371    13371           
=======================================
  Hits        11752    11752           
  Misses       1619     1619           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks clean. Do you not want to use find_package to avoid system libraries for some reason (e.g. specific versions or something)?

@paleolimbot
Copy link
Member Author

Do you not want to use find_package to avoid system libraries for some reason (e.g. specific versions or something)?

No specific reason, but it also doesn't cause any issues! In general it's pretty nice that you can clone/build without a package manager (e.g., no conda or brew installs) except for Arrow C++ (and I'd like to remove that when possible).

@paleolimbot paleolimbot marked this pull request as ready for review February 13, 2024 17:00
@paleolimbot paleolimbot merged commit 0a9f45f into apache:main Feb 13, 2024
32 checks passed
@paleolimbot paleolimbot deleted the add-first-benchmark branch February 13, 2024 21:11
eddelbuettel pushed a commit to eddelbuettel/arrow-nanoarrow that referenced this pull request Apr 10, 2024
@paleolimbot paleolimbot added this to the nanoarrow 0.5.0 milestone May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants