-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add basic benchmark setup #384
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
=======================================
Coverage 87.89% 87.89%
=======================================
Files 76 76
Lines 13371 13371
=======================================
Hits 11752 11752
Misses 1619 1619 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks clean. Do you not want to use find_package
to avoid system libraries for some reason (e.g. specific versions or something)?
No specific reason, but it also doesn't cause any issues! In general it's pretty nice that you can clone/build without a package manager (e.g., no conda or brew installs) except for Arrow C++ (and I'd like to remove that when possible). |
No description provided.